List of commits:
Subject Hash Author Date (UTC)
feat(choir): Add debuff buttons for raid fe66339420a9eb5e4823cc4fe45e0d97b2983073 Vladyslav Bondarenko 2021-11-17 00:55:54
feat(choir): Add texture to health bars ddaeb29d7ecfd95a98bcc85b3f4f7676c7ccd4d7 Vladyslav Bondarenko 2021-11-14 21:40:26
fix(choir)!: Obscure critical error 0f203b4d69f57240e97c66f1ab4510c6ac3e9276 Vladyslav Bondarenko 2021-11-11 12:52:02
feat(choir): Toggle button visibility given roster d193e7b5eb38cb3ac69d74eec1f96e00d90b6098 Vladyslav Bondarenko 2021-11-10 23:46:24
feat(choir)!: Add permanent raid frame 1839c35af4212c09038e972547d6b5893a9ce219 Vladyslav Bondarenko 2021-11-10 16:04:25
feat(choir)!: Employ Clearcasting subset feat 733c81538c3c965f07993fd7ddc482e724121b75 Vladyslav Bondarenko 2021-11-04 22:40:48
fix(choir): Improve shortcut binding keys eb636de6e3f7bada9f0064ffe4db1db3f6433f6c Vladyslav Bondarenko 2021-10-31 18:55:10
fix(choir): Improve choirBindingKey attribute handling 6c5c2214cc1809e5e5e59cd3672da3cca3f2701f Vladyslav Bondarenko 2021-10-31 13:23:24
feat(choir)!: Add spell shortcut prototype d34f22a6983ffc41122acb40d22e3cb29c208a3c Vladyslav Bondarenko 2021-10-31 12:39:39
feat(choir)!: Add spell effects on unit d581df9fce342709267a3221dead4d00b9d14319 Vladyslav Bondarenko 2021-10-31 10:49:19
feat(choir)!: Close spoiler by pressing Esc 22d7370011ac45d25a410a3f569183d0cc9fb232 Vladyslav Bondarenko 2021-10-29 16:10:08
feat(choir)!: Range indicator 931a0510b562986ec76dc22f329f4af4ed723cdf Vladyslav Bondarenko 2021-10-29 10:40:46
fix(choir)!: Health bar in combat a6622578dd5a1b4e4babf699a4cf1e4eb6bb70d6 Vladyslav Bondarenko 2021-10-28 07:42:57
feat(choir)!: Decorate unit buttons 4dc5ed44a9519b275f4256cfe4281110b7a94c9a Vladyslav Bondarenko 2021-10-25 21:20:56
feat(choir)!: Copy action bar binding 70ce056ffda7f12d913ce9a42b128ea257bdd0dc Vladyslav Bondarenko 2021-10-23 23:34:56
feat!: Initial commit 45c4e781e5ff0a69f8b0bea3a869e2384c7ca454 Vladyslav Bondarenko 2021-10-23 06:03:14
Commit fe66339420a9eb5e4823cc4fe45e0d97b2983073 - feat(choir): Add debuff buttons for raid
For every mini unit button in the custom raid frame add two indicators
at the bottom of the mini unit button. The indicators correspond to two
harmful effects on the unit that are the most ready to expire.

Additionally adjust the positioning of the relevant frames to allow for
user visibility.

Next improve the contextual positioning of the raid frames.
Author: Vladyslav Bondarenko
Author date (UTC): 2021-11-17 00:55
Committer name: Vladyslav Bondarenko
Committer date (UTC): 2021-11-17 00:55
Parent(s): 1eb0fb4f984e350bd9e53a04c2f759b00e03c8b6
Signer:
Signing key:
Signing status: N
Tree: 306a83c5099823655f9698285b96f6c61ea66591
File Lines added Lines deleted
choir.lua 39 3
File choir.lua changed (mode: 100644) (index adcdd38..fd2a30b)
... ... local function createClearcastingSubset(unitButton)
36 36 return harmSubset, helpSubset return harmSubset, helpSubset
37 37 end end
38 38
39 local function createClearcastingSubsetRaid(unitButton)
40 assert (unitButton ~= nil)
41
42 if not ClearcastingFrame then
43 trace('could not access Clearcasting module')
44 return
45 end
46
47 local createSubset = ClearcastingFrame.createSubset
48 assert (createSubset ~= nil)
49
50 --[[ FIXME Update indicator unit designation when unit button attribute changes at runtime.
51 -- This is not an expected use-case. Rather it is a matter of robustness. ]]--
52 local unitDesignation = unitButton:GetAttribute('unit')
53 assert (unitDesignation ~= nil)
54
55 local harmSubset = createSubset(unitButton, unitButton:GetName() .. 'HarmfulSubsetFrame',
56 unitDesignation, 'HARMFUL',
57 2, 1, 16, 32)
58 harmSubset:SetPoint('BOTTOMLEFT', 0, 0)
59
60 --[[
61 local t = {harmSubset:GetChildren()}
62 local i = 0
63 while (i < #t) do
64 i = i + 1
65 local b = t[i]
66 local label = b.text or _G[b:GetName() .. 'Text']
67 label:Hide()
68 end
69 ]]--
70
71 return harmSubset
72 end
73
39 74 local function createBindingKeyHandler(button) local function createBindingKeyHandler(button)
40 75 assert (button ~= nil) assert (button ~= nil)
41 76
 
... ... local function createRaidGroupFrame(raidFrame, groupNumber, unitSetOverride)
685 720 end end
686 721
687 722 local buttonWidth = 48 local buttonWidth = 48
688 local buttonHeight = 24 + 12 + 8
723 local buttonHeight = 24 + 12 + 8 + 36
689 724 local padding = 2 local padding = 2
690 725 local labelWidth = 60 local labelWidth = 60
691 726
 
... ... local function createRaidGroupFrame(raidFrame, groupNumber, unitSetOverride)
716 751 local n = groupFrame:GetName() .. 'RaidUnitButton' .. tostring(i) local n = groupFrame:GetName() .. 'RaidUnitButton' .. tostring(i)
717 752 local b = createUnitButton(groupFrame, n, unitDesignation, buttonWidth, buttonHeight) local b = createUnitButton(groupFrame, n, unitDesignation, buttonWidth, buttonHeight)
718 753 b:SetPoint('BOTTOMLEFT', labelWidth + (i - 1) * (padding + b:GetWidth()), 0) b:SetPoint('BOTTOMLEFT', labelWidth + (i - 1) * (padding + b:GetWidth()), 0)
754 createClearcastingSubsetRaid(b)
719 755 end end
720 756
721 757 groupFrame:RegisterEvent('PARTY_CONVERTED_TO_RAID') groupFrame:RegisterEvent('PARTY_CONVERTED_TO_RAID')
 
... ... local function createRaidFrame(rootFrame, spoilerHolder)
737 773 local maxSubgroupQuantity = 8 local maxSubgroupQuantity = 8
738 774
739 775 local buttonWidth = 48 local buttonWidth = 48
740 local buttonHeight = 24 + 12 + 8
776 local buttonHeight = 24 + 12 + 8 + 36
741 777 local padding = 2 local padding = 2
742 778
743 779 local labelWidth = 60 local labelWidth = 60
744 780 local raidFrame = CreateFrame('FRAME', 'ChoirRaidFrame', rootFrame) local raidFrame = CreateFrame('FRAME', 'ChoirRaidFrame', rootFrame)
745 781 raidFrame:SetSize(labelWidth + (padding + buttonWidth) * maxPartySize, raidFrame:SetSize(labelWidth + (padding + buttonWidth) * maxPartySize,
746 782 (padding + buttonHeight) * (maxSubgroupQuantity + 1)) (padding + buttonHeight) * (maxSubgroupQuantity + 1))
747 raidFrame:SetPoint('TOPLEFT', 0, -144)
783 raidFrame:SetPoint('TOPLEFT', 0, -64)
748 784
749 785 --[[ TODO Add any debuff indicator ]]-- --[[ TODO Add any debuff indicator ]]--
750 786 local j = 0 local j = 0
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/vrtc/choir

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/vrtc/choir

Clone this repository using git:
git clone git://git.rocketgit.com/user/vrtc/choir

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main